[Probably fixed] White noise after changing slot
[Probably fixed] White noise after changing slot
If you are listening to DMR in a slot and there is audio signal, if you press the star key to change slot and in the new slot there is no audio, a white noise can be heard. Should audio be turned off when changing slot? (maybe by calling terminate_digital()?)
Re: White noise after changing slot
I never hear this in normal operation
But if I change some optimisation settings it always has very loud white noise on all DMR signals.
Hence this sounds like another optimisation issue, but only in the version you have built yourself
But if I change some optimisation settings it always has very loud white noise on all DMR signals.
Hence this sounds like another optimisation issue, but only in the version you have built yourself
Re: White noise after changing slot
I can confirm the same happens with your latest build from the 22nd of January
Re: White noise after changing slot
The sound noise are low.. but I confirm this also in my own compilation.
Tested in duplex hotspot
Tested in duplex hotspot
- Attachments
-
[The extension sgl has been deactivated and can no longer be displayed.]
Re: White noise after changing slot
I tested this on several radios and I don't hear it at all.
So it seems that it only happens on some radios.
So it seems that it only happens on some radios.
Re: White noise after changing slot
Does this occur in the latest version ?
Re: White noise after changing slot
Ok
I will investigate
I will investigate
Re: White noise after changing slot
It still happens to me too.
I have tried using the methods init_sound() and init_digital() when changing slot. Both methods are used when changing the channel. Using them when changing the slot did not produce the expected results.
it is not really anoying at all, I can only hear it when at home in a quiet room, but can it have some impact in the battery life?
I have tried using the methods init_sound() and init_digital() when changing slot. Both methods are used when changing the channel. Using them when changing the slot did not produce the expected results.
it is not really anoying at all, I can only hear it when at home in a quiet room, but can it have some impact in the battery life?
Re: White noise after changing slot
Interesting theory, something worth investigating, maybe we need to add a close audio call after the key beep
Re: White noise after changing slot
I think there are several bugs.
1. I noticed that the audio amp gets turned on even if there is a signal on the other TG.
I tried to do a fix for this, on 15th Feb, but it had bad side effects for some people
I will need to find a better solution to prevent the amp turning on under that condition.
2. The beep system does not store the status of the audio amp prior to enabling the beep, and I think it probably does not turn the amp off after the beep I played.
However simply remembering the status of the audio amp prior to the beep enabling it, and restoring the state at the end of the beep would not work, because the DRM audio may be received during a beep, so the audio amp should not be always set back to the state prior to the beep.
Probably what is needed is 2 variables
One for the DMR system audio amp enable status and one of the beep system audio amp enable.
And only turn the amp off when both of those variables show that neither the DMR or beep system , needs the speaker to be enabled.
Also,
there is some code which I think reads the state of the audio amp enable pin, and uses it to determine if there is any audio.
This may be in the scanning code, but I can’t remember
This is not ideal, and it should instead use the new variable that just contains whether the DMR or FM system has enabled the audio amp
1. I noticed that the audio amp gets turned on even if there is a signal on the other TG.
I tried to do a fix for this, on 15th Feb, but it had bad side effects for some people
I will need to find a better solution to prevent the amp turning on under that condition.
2. The beep system does not store the status of the audio amp prior to enabling the beep, and I think it probably does not turn the amp off after the beep I played.
However simply remembering the status of the audio amp prior to the beep enabling it, and restoring the state at the end of the beep would not work, because the DRM audio may be received during a beep, so the audio amp should not be always set back to the state prior to the beep.
Probably what is needed is 2 variables
One for the DMR system audio amp enable status and one of the beep system audio amp enable.
And only turn the amp off when both of those variables show that neither the DMR or beep system , needs the speaker to be enabled.
Also,
there is some code which I think reads the state of the audio amp enable pin, and uses it to determine if there is any audio.
This may be in the scanning code, but I can’t remember
This is not ideal, and it should instead use the new variable that just contains whether the DMR or FM system has enabled the audio amp