Disable tone filter?

Discussions related to the firmware code development
KC7RBW
Posts: 159
Joined: Wed Nov 20, 2019 1:23 am

Re: Disable tone filter?

Post by KC7RBW » Tue Feb 25, 2020 12:48 am

As I'm writing the code I wonder if the analog filter values should be "None" and "Tone" rather than "None" and "CTCSS" because when DCS features are eventually added I can't see how it would make any sense to have "None", "CTCSS", "CTCSS, DCS", and "DCS" options as opposed to just "None" and "Tone" and the firmware knows which type of tone is in use.

Unlike DMR where CC and TS filters can be used together DCS and CTCSS are mutually exclusive and both are effectively "tone squelch" systems.

KC7RBW
Posts: 159
Joined: Wed Nov 20, 2019 1:23 am

Re: Disable tone filter?

Post by KC7RBW » Tue Feb 25, 2020 2:47 am

I think I've got this all worked out. This is what it looks like:
analog-filter-none.png
analog-filter-none.png (2.56 KiB) Viewed 1593 times
analog-filter-ctcss.png
analog-filter-ctcss.png (2.52 KiB) Viewed 1593 times
Attached is a build with this patch based on 893c04f which is where master was at when I rebased my branch.

Works in both Channel and VFO modes. I bumped the non-volatile magic, so this should factory reset, because the setting was added to that struct.

If I get feedback that it should be "Tone" instead of "CTCSS" (see my last comment on this thread) then I'll update of course.

PR submitted at https://github.com/rogerclarkmelbourne/ ... 7/pull/447
Attachments

[The extension sgl has been deactivated and can no longer be displayed.]


Post Reply